Skip to content

[dotnet] [bidi] Unignore some internal tests #16968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nvborisenko merged 3 commits into from
Jan 22, 2026
+1 −21
Merged

[dotnet] [bidi] Unignore some internal tests #16968

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bfa8f16
Update BrowsingContextEventsTest.cs
nvborisenko Jan 21, 2026
b83add0
Update EmulationTest.cs
nvborisenko Jan 21, 2026
ef2aaef
Update NetworkTest.cs
nvborisenko Jan 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions dotnet/test/common/BiDi/BrowsingContext/BrowsingContextEventsTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ namespace OpenQA.Selenium.BiDi.BrowsingContext;
internal class BrowsingContextEventsTest : BiDiTestFixture
{
[Test]
[IgnoreBrowser(Selenium.Browser.Firefox, "Not supported yet?")]
public async Task CanListenDownloadWillBeginEvent()
{
await context.NavigateAsync(UrlBuilder.WhereIs("downloads/download.html"), new() { Wait = ReadinessState.Complete });
Expand All @@ -42,11 +41,10 @@ public async Task CanListenDownloadWillBeginEvent()
Assert.That(eventArgs, Is.Not.Null);
Assert.That(eventArgs.Context, Is.EqualTo(context));
Assert.That(eventArgs.Url, Does.EndWith("downloads/file_1.txt"));
Assert.That(eventArgs.SuggestedFilename, Is.EqualTo("file_1.txt"));
Assert.That(eventArgs.SuggestedFilename, Does.Contain("file_1")); // Avoid incremental prefix
}

[Test]
[IgnoreBrowser(Selenium.Browser.Firefox, "Not supported yet?")]
public async Task CanListenDownloadEndEvent()
{
await context.NavigateAsync(UrlBuilder.WhereIs("downloads/download.html"), new() { Wait = ReadinessState.Complete });
Expand Down
15 changes: 0 additions & 15 deletions dotnet/test/common/BiDi/Emulation/EmulationTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ namespace OpenQA.Selenium.BiDi.Emulation;
internal class EmulationTest : BiDiTestFixture
{
[Test]
[IgnoreBrowser(Selenium.Browser.Firefox, "Not supported yet?")]
public void CanSetTimezoneOverride()
{
Assert.That(async () =>
Expand All @@ -35,7 +34,6 @@ public void CanSetTimezoneOverride()
}

[Test]
[IgnoreBrowser(Selenium.Browser.Firefox, "Not supported yet?")]
public void CanSetTimezoneOverrideToDefault()
{
Assert.That(async () =>
Expand All @@ -46,9 +44,6 @@ public void CanSetTimezoneOverrideToDefault()
}

[Test]
[IgnoreBrowser(Selenium.Browser.Chrome, "Not supported yet?")]
[IgnoreBrowser(Selenium.Browser.Edge, "Not supported yet?")]
[IgnoreBrowser(Selenium.Browser.Firefox, "Not supported yet?")]
public void CanSetUserAgentOverride()
{
Assert.That(async () =>
Expand All @@ -59,9 +54,6 @@ public void CanSetUserAgentOverride()
}

[Test]
[IgnoreBrowser(Selenium.Browser.Chrome, "Not supported yet?")]
[IgnoreBrowser(Selenium.Browser.Edge, "Not supported yet?")]
[IgnoreBrowser(Selenium.Browser.Firefox, "Not supported yet?")]
public void CanSetUserAgentOverrideToDefault()
{
Assert.That(async () =>
Expand Down Expand Up @@ -118,8 +110,6 @@ public void CanSetForcedColorsModeThemeOverrideToDefault()
}

[Test]
[IgnoreBrowser(Selenium.Browser.Chrome, "Not supported yet?")]
[IgnoreBrowser(Selenium.Browser.Edge, "Not supported yet?")]
[IgnoreBrowser(Selenium.Browser.Firefox, "Not supported yet?")]
public void CanSetScriptingEnabled()
{
Expand All @@ -131,8 +121,6 @@ public void CanSetScriptingEnabled()
}

[Test]
[IgnoreBrowser(Selenium.Browser.Chrome, "Not supported yet?")]
[IgnoreBrowser(Selenium.Browser.Edge, "Not supported yet?")]
[IgnoreBrowser(Selenium.Browser.Firefox, "Not supported yet?")]
public void CanSetScriptingEnabledToDefault()
{
Expand All @@ -144,7 +132,6 @@ public void CanSetScriptingEnabledToDefault()
}

[Test]
[IgnoreBrowser(Selenium.Browser.Firefox, "Not supported yet?")]
public void CanSetScreenOrientationOverride()
{
var orientation = new ScreenOrientation(ScreenOrientationNatural.Portrait, ScreenOrientationType.PortraitPrimary);
Expand All @@ -157,7 +144,6 @@ public void CanSetScreenOrientationOverride()
}

[Test]
[IgnoreBrowser(Selenium.Browser.Firefox, "Not supported yet?")]
public void CanSetScreenOrientationOverrideToDefault()
{
Assert.That(async () =>
Expand All @@ -170,7 +156,6 @@ public void CanSetScreenOrientationOverrideToDefault()
[Test]
[IgnoreBrowser(Selenium.Browser.Chrome, "Not supported yet?")]
[IgnoreBrowser(Selenium.Browser.Edge, "Not supported yet?")]
[IgnoreBrowser(Selenium.Browser.Firefox, "Not supported yet?")]
public void CanSetScreenSettingsOverride()
{
var screenArea = new ScreenArea(300, 200);
Expand Down
3 changes: 0 additions & 3 deletions dotnet/test/common/BiDi/Network/NetworkTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,9 +260,6 @@ public void CanSetCacheBehavior()
}

[Test]
[IgnoreBrowser(Selenium.Browser.Chrome, "Not supported yet?")]
[IgnoreBrowser(Selenium.Browser.Edge, "Not supported yet?")]
[IgnoreBrowser(Selenium.Browser.Firefox, "Not supported yet?")]
public async Task CanSetExtraHeaders()
{
var result = await bidi.Network.SetExtraHeadersAsync([new Header("x-test-header", "test-value")]);
Expand Down