Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IContextAware interface #305

Closed
wants to merge 1 commit into from
Closed

IContextAware interface #305

wants to merge 1 commit into from

Conversation

TikhomirovSergey
Copy link
Contributor

Appium project needs this. If the similar interface exists at
selenium-java so why it can't be at C#/.Net client. :)

@jimevans
Copy link
Member

I'm disinclined to add this into the .NET language bindings. Just because the Java bindings do something is not, in itself, sufficient reason to do so in .NET. Frankly, in this case the fact that the Java language bindings provides this interface is a mistake, in my opinion, since it adds pieces to the API that do not relate to driving a browser, which leads to confusion and bloat. Furthermore, there's nothing preventing the Appium project from adding this to its own .NET driver library. I'm honestly quite surprised it hasn't done so already. I'll wait a reasonable amount of time before closing this pull request for additional comment, but silence on the matter will be interpreted as assent.

@TikhomirovSergey
Copy link
Contributor Author

This interface is already included in Appium library. We just consider that we will reimplement it if this will be included in Selenium.

But. In another hand, why interfaces like IRotatable are included in Selenium .Net? It is not implemented too on Selenium side and there is the similar interface included in Selenium for Java.

Presence of the interface like this at Selenium .Net is not important for Appium project for now.

@jimevans
Copy link
Member

IRotatable probably shouldn't be anymore, but is a holdover from when there was an Android and iPhone driver supplied by the WebDriver project itself. Now that those drivers are no longer part of the project, that and the IHasTouchScreen interfaces are legacies from that era. I'd rather not pollute the API anymore than it already is.

Anyway, as other projects who require it already provide the required interface, I'll close this PR.

@jimevans jimevans closed this Mar 27, 2015
yiming-tang-cs pushed a commit to ponder-lab/selenium that referenced this pull request Jan 2, 2020
Start retransmission timer onSent.

Signed-off-by: Achim Kraus <achim.kraus@bosch-si.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants