-
-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rb] Adding method to send DevTools commands to Chrome and a helper method to enable downloads on headless Chrome. #5583
Conversation
…ds to Chrome DevTools debugger. For some reason specs for headless mode are not passing. Refer: bayandin/chromedriver@9d18be0
… using data URLs.
e28ab0a
to
f8a6868
Compare
driver.find_element(css: 'a').click | ||
|
||
# Wait for file to download | ||
5.times do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This logic can be used using a wait.until command much cleaner, and with more control. If you wait for the temporary file not to be there (It's hard to check but I "think" I may have mentioned this before.
After talking with the chromedriver team, the See the issue raised in the chromium bugtracker: https://bugs.chromium.org/p/chromedriver/issues/detail?id=2307 |
How Can I do that? Can you please tell me the steps? I use Ubuntu |
I don't know how I missed that PR at all 😕 The proposed changes were actually implemented in f77d2f9, so users can use Sorry if this PR was a waste of your time, I somehow missed it completely. Is there anything else we need to take from here? |
Hello, maybe someone know how to send DevTools command? I am able to use
but I can not subscribe to event:
|
For: #5159
Files can now be downloaded in headless mode after setting the download directory's path using the
#download_path=
helper.Working fine with Chrome 65 (chromedriver 2.36). For earlier versions of Chrome/chromedriver I was facing crashes when downloading files in headless mode.
X
in the preceding checkbox, I verify that I have signed the Contributor License AgreementThis change is