-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[atoms] Fix getText atom for unicode charater middle of word #8736
Conversation
Encountered some issues running test locally, |
Hi! Thank you for the contribution! Thank you, also, for pointing out that the
It looks your new test cases are failing, but once they pass, I'd be very happy to merge this change in! |
The change to getText atom by commit c065dda does not handle case when unicode character is in the middle of a word, and unicode character will be incorrectly capitalized (see https://bugs.chromium.org/p/chromedriver/issues/detail?id=3611). The problem is \b mark the boundary between word character and unicode character as a boundary. This is fixed by explicitly using unicode flag and specifying unicode character and unicode symbol.
Hi, thanks for fixing the test framework! |
I'd suspect that file encodings are to blame. I think the server expects everything to be in UTF-8 |
Add |
Also, this patch breaks other tests. |
Thanks, after adding |
Add charset for utf-8 in text_test.html
26ac789
to
b40abb0
Compare
Looks like a merge must have fixed the tests that were failing. I have merged this PR, thanks for making it work |
The change to getText atom by commit c065dda
does not handle case when unicode character is in the middle
of a word, and unicode character will be incorrectly capitalized
(see https://bugs.chromium.org/p/chromedriver/issues/detail?id=3611).
The problem is \b mark the boundary between word character and
unicode character as a boundary. This is fixed by explicitly using
unicode flag and specifying unicode character and unicode symbol
in the regex.
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Motivation and Context
Types of changes
Checklist