Merge remote-tracking branch 'upstream/trunk' into trunk

SeleniumHQ · Mar 21, 2023 · 4e9ebd5 · 4e9ebd5
2 parents 83af0b3 + 35be07d
commit 4e9ebd5
Show file tree

Hide file tree

Showing 31 changed files with 453 additions and 1,141 deletions.
diff --git a/.github/workflows/dotnet-examples.yml b/.github/workflows/dotnet-examples.yml
@@ -37,15 +37,6 @@ jobs:
       uses: actions/setup-dotnet@v3
       with:
         dotnet-version: 5.0.x
-    - name: Install Chrome
-      uses: browser-actions/setup-chrome@latest
-    - name: Install Edge
-      uses: browser-actions/setup-edge@latest
-    - name: Install Firefox
-      uses: abhi1693/setup-browser@v0.3.5
-      with:
-        browser: firefox
-        version: latest
     - name: Run tests
       uses: nick-invision/retry@v2.8.3
       with:

diff --git a/.github/workflows/java-examples.yml b/.github/workflows/java-examples.yml
@@ -38,15 +38,6 @@ jobs:
       with:
         distribution: 'temurin'
         java-version: 8
-    - name: Install Chrome
-      uses: browser-actions/setup-chrome@latest
-    - name: Install Edge
-      uses: browser-actions/setup-edge@latest
-    - name: Install Firefox
-      uses: abhi1693/setup-browser@v0.3.5
-      with:
-        browser: firefox
-        version: latest
     - name: Run Tests
       uses: nick-invision/retry@v2.8.3
       with:

diff --git a/.github/workflows/js-examples.yml b/.github/workflows/js-examples.yml
@@ -33,15 +33,6 @@ jobs:
     - name: Start Xvfb
       if: matrix.os == 'ubuntu-latest'
       run: Xvfb :99 &
-    - name: Install Chrome
-      uses: browser-actions/setup-chrome@latest
-    - name: Install Edge
-      uses: browser-actions/setup-edge@latest
-    - name: Install Firefox
-      uses: abhi1693/setup-browser@v0.3.5
-      with:
-        browser: firefox
-        version: latest
     - name: Install Requirements
       working-directory: ./examples/javascript
       run: npm install

diff --git a/.github/workflows/kotlin-examples.yml b/.github/workflows/kotlin-examples.yml
@@ -38,15 +38,6 @@ jobs:
       with:
         distribution: 'temurin'
         java-version: 8
-    - name: Install Chrome
-      uses: browser-actions/setup-chrome@latest
-    - name: Install Edge
-      uses: browser-actions/setup-edge@latest
-    - name: Install Firefox
-      uses: abhi1693/setup-browser@v0.3.5
-      with:
-        browser: firefox
-        version: latest
     - name: Run tests
       uses: nick-invision/retry@v2.8.3
       with:

diff --git a/.github/workflows/python-examples.yml b/.github/workflows/python-examples.yml
@@ -33,15 +33,6 @@ jobs:
     - name: Start Xvfb
       if: matrix.os == 'ubuntu-latest'
       run: Xvfb :99 &
-    - name: Install Chrome
-      uses: browser-actions/setup-chrome@latest
-    - name: Install Edge
-      uses: browser-actions/setup-edge@latest
-    - name: Install Firefox
-      uses: abhi1693/setup-browser@v0.3.5
-      with:
-        browser: firefox
-        version: latest
     - name: Set up Python
       uses: actions/setup-python@v4
       with:

diff --git a/.github/workflows/ruby-examples.yml b/.github/workflows/ruby-examples.yml
@@ -38,15 +38,6 @@ jobs:
         with:
           ruby-version: 2.7
           bundler-cache: true
-      - name: Install Chrome
-        uses: browser-actions/setup-chrome@latest
-      - name: Install Edge
-        uses: browser-actions/setup-edge@latest
-      - name: Install Firefox
-        uses: abhi1693/setup-browser@v0.3.5
-        with:
-          browser: firefox
-          version: latest
       - name: Install Gems
         working-directory: ./examples/ruby
         run: bundle install

diff --git a/examples/java/src/test/java/dev/selenium/browsers/ChromeTest.java b/examples/java/src/test/java/dev/selenium/browsers/ChromeTest.java
@@ -26,4 +26,11 @@ public void headlessOptions() {
         driver = new ChromeDriver(options);
     }
 
+    @Test
+    public void keepBrowserOpen() {
+        ChromeOptions options = new ChromeOptions();
+        options.setExperimentalOption("detach", true);
+        driver = new ChromeDriver(options);
+    }
+
 }