-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update first_script.en.md #1780
base: trunk
Are you sure you want to change the base?
Conversation
In step 7 for Python, the code block is missing line 18 which creates the message variable. This way people that are following along the `"getting_started"` tutorial won't be as confused.
👷 Deploy request for selenium-dev pending review.Visit the deploys page to approve it
|
PR Reviewer Guide 🔍
|
PR Code Suggestions ✨No code suggestions found for PR. |
Found this error since I was trying to do the tutorial myself for the first time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HI @darrenqchen ,
Thank you for the PR.
Your feedback is indeed beneficial in our efforts towards refining and enhancing our documentation.
To maintain consistency across all language versions, could you please replicate the changes you made on the main page to the other translated pages (pt-br, zh-cn, ja)?
If you need any assistance or prefer me to implement the changes, kindly let me know.
Thanks,
Sri
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
User description
In step 7 for Python, the code block is missing line 18 from
examples/python/tests/getting_started/first_script.py
which creates themessage
variable. This way people that are following along the"getting_started"
tutorial won't be as confused.Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to review and merge it quickly
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.
Description
Motivation and Context
Types of changes
Checklist
PR Type
Documentation
Description
message
variable creation is visible.Changes walkthrough 📝
first_script.en.md
Fix missing line in Python code block for tutorial
website_and_docs/content/documentation/webdriver/getting_started/first_script.en.md
message
variable is included in thetutorial.