-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update python locators docs #1903
base: trunk
Are you sure you want to change the base?
Update python locators docs #1903
Conversation
Add examples to the python docs for locators
👷 Deploy request for selenium-dev pending review.Visit the deploys page to approve it
|
PR Reviewer Guide 🔍
|
PR Code Suggestions ✨
|
Could I get a review please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution @pmartinez1 ! A few changes must be made before it can be properly reviewed:
pytest import is unnecessary, pytest will not run a function if it is not prefixed by test unless explicitly called in a test function. Line 70 can be removed as well
Thanks for pointing that out. I've updated the PR. |
User description
Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to review and merge it quickly
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.
Description
This PR moves the code to the test_locators.py file in the python/tests directory.
Motivation and Context
Helps the code be more organized, instead of having stand alone code that has not been tested.
Types of changes
Checklist
PR Type
Tests, Documentation
Description
Changes walkthrough 📝
test_locators.py
Add test cases for various Selenium locators in Python
examples/python/tests/elements/test_locators.py
partial link text, tag name, and XPath.
locators.en.md
Update Python locator examples to reference test file
website_and_docs/content/documentation/webdriver/elements/locators.en.md
locators.ja.md
Update Python locator examples to reference test file
website_and_docs/content/documentation/webdriver/elements/locators.ja.md
locators.pt-br.md
Update Python locator examples to reference test file
website_and_docs/content/documentation/webdriver/elements/locators.pt-br.md
locators.zh-cn.md
Update Python locator examples to reference test file
website_and_docs/content/documentation/webdriver/elements/locators.zh-cn.md