issue #138 refactor: group post info api change, unused state delete

Selody-project · Feb 26, 2024 · 4092e94 · 4092e94
1 parent c4e6b58
commit 4092e94
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 15 deletions.
diff --git a/src/components/Group/GroupFeed/GroupFeed.jsx b/src/components/Group/GroupFeed/GroupFeed.jsx
@@ -11,7 +11,7 @@ import { FeedSection } from "./GroupFeed.styles";
 const GroupFeed = ({ groupId, leaderName }) => {
 	const dispatch = useDispatch();
 
-	const { allGroupPosts, allGroupPostsIsEnd, isLoading } = useSelector(
+	const { allGroupPosts, allGroupPostsIsEnd } = useSelector(
 		(state) => state.post,
 	);
 
@@ -28,10 +28,6 @@ const GroupFeed = ({ groupId, leaderName }) => {
 		}
 	};
 
-	if (isLoading) {
-		return <div>피드 정보 불러오는 중...</div>;
-	}
-
 	if (allGroupPosts.length === 0) {
 		return <EmptyFeed />;
 	}

diff --git a/src/features/post/post-service.js b/src/features/post/post-service.js
@@ -19,8 +19,8 @@ export const getGroupAllPosts = createAsyncThunk(
 	},
 );
 
-export const getGroupPosts = createAsyncThunk(
-	"post/getGroupPosts",
+export const getGroupPostInfo = createAsyncThunk(
+	"post/getGroupPostInfo",
 	async ({ groupId, postId }, thunkAPI) => {
 		const data = await commonThunk(
 			{

diff --git a/src/features/post/post-slice.js b/src/features/post/post-slice.js
@@ -4,31 +4,30 @@ import { createSlice, isAnyOf } from "@reduxjs/toolkit";
 
 import {
 	getGroupAllPosts,
-	getGroupPosts,
+	getGroupPostInfo,
 	getMyGroupPosts,
 	likeGroupPost,
 	cancelLikeGroupPost,
 	deleteGroupPost,
 } from "./post-service";
 
 const initialState = {
-	currentGroupPost: null,
+	postInfo: null,
 	allGroupPosts: [],
 	myGroupPosts: [],
 	allGroupPostslastRecordId: 0,
 	allGroupPostsIsEnd: false,
 	myGroupPostslastRecordId: 0,
 	isLoading: true,
 	isEnd: false,
-	isEmpty: false,
 };
 
 const postSlice = createSlice({
 	name: "post",
 	initialState,
 	reducers: {
 		resetPostStateForGroupPage: (state) => {
-			state.currentGroupPost = null;
+			state.postInfo = null;
 			state.allGroupPosts = [];
 			state.allGroupPostslastRecordId = 0;
 			state.allGroupPostsIsEnd = false;
@@ -47,9 +46,9 @@ const postSlice = createSlice({
 						payload.feed[payload.feed.length - 1].postId;
 				}
 			})
-			.addCase(getGroupPosts.fulfilled, (state, { payload }) => {
+			.addCase(getGroupPostInfo.fulfilled, (state, { payload }) => {
 				state.isLoading = false;
-				state.currentGroupPost = payload;
+				state.postInfo = payload;
 			})
 			.addCase(getMyGroupPosts.fulfilled, (state, { payload }) => {
 				state.isLoading = false;
@@ -84,7 +83,7 @@ const postSlice = createSlice({
 			.addMatcher(
 				isAnyOf(
 					getGroupAllPosts.pending,
-					getGroupPosts.pending,
+					getGroupPostInfo.pending,
 					getMyGroupPosts.pending,
 					likeGroupPost.pending,
 					cancelLikeGroupPost.pending,
@@ -97,7 +96,7 @@ const postSlice = createSlice({
 			.addMatcher(
 				isAnyOf(
 					getGroupAllPosts.rejected,
-					getGroupPosts.rejected,
+					getGroupPostInfo.rejected,
 					getMyGroupPosts.rejected,
 					likeGroupPost.rejected,
 					cancelLikeGroupPost.rejected,