Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
sikkzz
requested changes
Nov 20, 2023
sikkzz
approved these changes
Nov 26, 2023
…ponent in styles file
kimyoungyin
force-pushed
the
147-front-task-랜딩페이지-개선
branch
from
dd22940 to
2ad844f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
설명
반응형 디자인
LandingHeader,LandingMain의 최대 너비는1440px로 제한768px이하의 경우LandingMain의 정렬이 column으로 변경typing library 변경(react-type-animation)
저는 한 번 타이핑 된 후 유지되는 것을 원했는데,
기존에 사용되었던 방식은 '무조건 텍스트가 지워져야 하는(infinity)` 문제가 있어서 대체했습니다.
애니메이션
기존에 framer-motion을 사용하여 구현이 되어 있었으며, 해당 애니메이션을 그대로 이어감
main.content의 경우: 첫 줄 -> 두 번째 줄 -> 시작하기 버튼
순으로 보이도록 시간 조정
SelodyLogo재사용iconConstants로 svg를 사용하지 않고(어차피 재사용할 건 SelodyLogo 컴포넌트임),SelodyLogo컴포넌트를 만들어 필요한 곳에 대체하였습니다.prop으로는size를 받습니다.테스트
initial render에 대한 테스트 진행
Demo(font-weight는 변경됨)
768px이하~
1440px그 이상의 너비