192 front task 공유 일정 페이지 일정 후보 모달 및 후보 등록 #208

kimyoungyin · 2024-04-26T07:12:47Z

설명

[FRONT-TASK] 공유 일정 페이지 - 일정 후보 모달 및 후보 등록 #192
공유 일정 페이지 aside에 리스트는 투표 기능과 함께 구현할 예정이여서 간단한 div로만 대체함

테스트

refactor: move shared styled components to ScheduleModal.Shared.styles.js and use them in ScheduleModal and ScheduleProposalModal

…n ScheduleItemList

…여러 날짜'

…on in ExtraGroupMembers

…Members

…any groups

…tate.isRedirected is true

…e it's triggering condtion with ui-slice

…ch params

…ct from event.target to event.currentTarget

…ing is true to prevent blinking

…Modal

…mendedScheduleProposals

…oposals's params

… 날짜' and '여러 날짜'

… Modal

…l in ScheduleModal

…odal

…ot-allowed cursor

…f EditForm is on

src/components/Common/SchedulePage/CalendarContainer/CustomCalendar/GroupMenu/GroupMenu.jsx

sikkzz · 2024-05-06T13:22:05Z

src/components/Common/ScheduleProposalModal/ScheduleProposalModal.jsx

추천받기 버튼 width가 어색한데 아래 등록하기 버튼이랑 맞추는건 어떠세요?

저는 이 폼 자체를 제출하는 거랑 버튼을 같은 디자인으로 가면 안 될 것 같아서 저렇게 했었는데 이런 측면에서 생각해봐도 변경하는게 나을까요? 일단 지수님한테도 여쭤볼게요

지수님하고 얘기 나눠보니까 너비만 수정하기로 했습니다. disabled 상태에서도 높이 차이가 있으니 색 구분이 되지 않을까 싶어 그대로 가려고 합니다.

sikkzz · 2024-05-06T13:28:00Z

개인일정쪽 schedulModal이랑 EditedProposalForm, ScheduleProposalModal 각각 기능이 비슷한 함수들이 있지 않나요? 이걸 좀 모듈화 시켜서 사용하는게 좋아 보이는데 어떠신가요

sikkzz · 2024-05-06T13:29:41Z

다른 계정에서 공유 일정 작동 안하는거도 확인 다시 부탁드려요

…h data-testid contained svg buttons

kimyoungyin · 2024-05-08T02:35:36Z

다른 계정에서 공유 일정 작동 안하는거도 확인 다시 부탁드려요

해결: 관련 노션 링크

kimyoungyin · 2024-05-08T04:55:27Z

개인일정쪽 schedulModal이랑 EditedProposalForm, ScheduleProposalModal 각각 기능이 비슷한 함수들이 있지 않나요? 이걸 좀 모듈화 시켜서 사용하는게 좋아 보이는데 어떠신가요

저도 이 생각으로 시도를 조금 해봤었는데, 각자 다루는 form value들이 약간씩 달라서 조금 힘들더군요.. 다시 보고 분리하면 좋겠다 싶은 부분은 진행해볼게요

…Time is changed

…기' button

…me is valid

kimyoungyin added 30 commits February 23, 2024 15:26

issue #192 feat: create ScheduleProposalModal

5ce06b9

refactor: move shared styled components to ScheduleModal.Shared.styles.js and use them in ScheduleModal and ScheduleProposalModal

issue #192 feat: open ScheduleProposalModal if click '후보 추가' button i…

753d83a

…n ScheduleItemList

issue #192 test: trigger opening ScheduleProposalModal

a2da1c7

issue #192 feat: create RadiosDiv

3030bc6

issuse #192 test: check initially checked input between '단일 날짜' and '…

77cca5f

…여러 날짜'

issue #192 refactor: change ExtraMembers-dropdown svg and it's positi…

d2fa119

…on in ExtraGroupMembers

issue #192 feat: add group iamge in GroupSelect options

af0e44e

issue #192 test: set testid to GroupSelect options with image

9aa6d93

issue #192 refactor: change avatar size in GroupSelect and ExtraGroup…

eba3d47

…Members

issue #192 feat: redirect to PersonalSchedulePage if user don't have …

d597612

…any groups

issue #192 feat: render EmptyUserGroupNotificationModal if location.s…

59ff1cb

…tate.isRedirected is true

issue #192 feat: set EmptyUserGroupNotificationModal layout and chang…

13b95ed

…e it's triggering condtion with ui-slice

issue #192 fix: change EmptyUserGroupNotificationModal link with sear…

87b3273

…ch params

issue 192 fix: change the way how to get value of button in GroupSele…

04c2067

…ct from event.target to event.currentTarget

issue #192 fix: use checked prop with onChange instead of onClick

6b9d348

issue #192 refactor: render skeleton in GroupMenu if isUserGroupFetch…

4c109c3

…ing is true to prevent blinking

issue #192 test: initial rendering proposalParmas in ScheduleProposal…

287e00a

…Modal

issue #192 feat: initial rendering proposalParmas in ScheduleProposal…

4786168

…Modal

issue #192 feat: create getScheduleProposals thunk and schedule.recom…

be4ae43

…mendedScheduleProposals

issue #192 refactor: add startTimeStr and endTimeStr in getSchedulePr…

08dedd2

…oposals's params

issue #192 refactor: utilize getTimeString function in ScheduleItem

8a4aba8

issue #192 refactor: split shareable components in ScheduleModal

d92c674

issue #192 test: render '추천받기' button and remove unused labelText '단일…

f777c10

… 날짜' and '여러 날짜'

issue #192: make DateAndTime shareable in ScheduleProposalModal

257c21f

issue #192 feat: create DurationPicker based on TimePicker and use in…

bb8f3e0

… Modal

issue #192 test: initial render components in '추천 받기' heading

adffd6b

issue #192 refactor: change unused value and validation about proposa…

486cb73

…l in ScheduleModal

issue #192 feat: add '직접 만들기' button end of recommendedScheduleProposals

75bda02

issue #192 test: intial render '직접 만들기' button in ScheduleProposalModal

b4d9d4c

issue #192 feat: set left, right slide animation in ScheduleProposalM…

f8a8c66

…odal

issue #192 feat: not allow typing if isSlideOnEditForm is true with n…

b884ced

…ot-allowed cursor

kimyoungyin requested a review from sikkzz April 26, 2024 07:12

kimyoungyin self-assigned this Apr 26, 2024

kimyoungyin added the enhancement New feature or request label Apr 26, 2024

issue #192 design: set 50% opacity on titleInput and DetailTextarea i…

cfff2f9

…f EditForm is on

sikkzz requested changes May 6, 2024

View reviewed changes

kimyoungyin added 12 commits May 7, 2024 10:34

issue #192 test: render title

8874193

issue #192 fix: fix property typo from endTime to endTimeStr

31b9fb4

issue #192 test initial render ScheduleProposalModal

aea637f

issue #192 feat, test: add placeholderText in ScheduleProposalModal

fb66926

issue #192 test: toggle proposalEditForm in ScheduleProposalModal wit…

4bdebb3

…h data-testid contained svg buttons

issue #192 fix: use groupId on endpoint in getScheduleProposals

0d8774a

issue #192 test: get recommended proposals with mock handler

e35d70d

issue #192 test: add proposal myself

2a6c1b7

issue #192 test: edit proposal

c20b9da

issue #192 test: enroll one proposal with handler

00b5800

issue #192 test: set startDate and endDate as a global value

77ab95a

issue #192 refactor: use object destructuring in GroupMenu

3b905c6

kimyoungyin closed this May 8, 2024

kimyoungyin reopened this May 8, 2024

kimyoungyin added 4 commits May 8, 2024 14:12

issue #192 refactor: create util which initialize endTime after start…

e9ed7d4

…Time is changed

issue #192 design: equalize button's width for '추천받기' button and '등록하…

7dfa943

…기' button

issue #192 refactor: use util which check startDateTime and EndDateTi…

ddfc0fb

…me is valid

issue #192 refactor: create util about validate schedule form values

680857c

kimyoungyin requested a review from sikkzz May 17, 2024 07:00

kimyoungyin merged commit 3e378dd into 179-front-task-공유-일정-페이지-구현 Jun 17, 2024
1 check passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

192 front task 공유 일정 페이지 일정 후보 모달 및 후보 등록 #208

192 front task 공유 일정 페이지 일정 후보 모달 및 후보 등록 #208

kimyoungyin commented Apr 26, 2024 •

edited

Loading

sikkzz May 6, 2024

kimyoungyin May 8, 2024

kimyoungyin May 8, 2024

sikkzz commented May 6, 2024

sikkzz commented May 6, 2024

kimyoungyin commented May 8, 2024

kimyoungyin commented May 8, 2024

192 front task 공유 일정 페이지 일정 후보 모달 및 후보 등록 #208

192 front task 공유 일정 페이지 일정 후보 모달 및 후보 등록 #208

Conversation

kimyoungyin commented Apr 26, 2024 • edited Loading

설명

테스트

sikkzz May 6, 2024

Choose a reason for hiding this comment

kimyoungyin May 8, 2024

Choose a reason for hiding this comment

kimyoungyin May 8, 2024

Choose a reason for hiding this comment

sikkzz commented May 6, 2024

sikkzz commented May 6, 2024

kimyoungyin commented May 8, 2024

kimyoungyin commented May 8, 2024

kimyoungyin commented Apr 26, 2024 •

edited

Loading