Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have inputs resolved through names and not indeces #20 #32

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

ARoefer
Copy link

@ARoefer ARoefer commented Jun 24, 2017

Solution for issue "Have inputs resolved through names and not indeces #20"
README listing structure of the implementation is on the branch.

@codecov-io
Copy link

codecov-io commented Jun 24, 2017

Codecov Report

Merging #32 into master will increase coverage by 0.33%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #32      +/-   ##
==========================================
+ Coverage   54.54%   54.88%   +0.33%     
==========================================
  Files           6        6              
  Lines         770      778       +8     
  Branches       46       46              
==========================================
+ Hits          420      427       +7     
- Misses        350      351       +1
Impacted Files Coverage Δ
...ssiongraph/include/kdl/expressiontree_rotation.hpp 87.14% <0%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62c00eb...479436a. Read the comment docs.

@airballking
Copy link
Member

@ARoefer thank you for this pull request. This is an exciting new feature. I'll try to review it in the next 2 days.

@ARoefer
Copy link
Author

ARoefer commented Oct 9, 2017

Sorry about that. I didn't notice that it wouldn't merge correctly.

@airballking
Copy link
Member

No problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants