refactor(Transition): rename prop unmountOnExit -> unmountOnHide

Semantic-Org · Jul 26, 2017 · 9816f61 · 9816f61
1 parent fadb601
commit 9816f61
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 12 deletions.
diff --git a/docs/app/Examples/modules/Transition/Types/index.js b/docs/app/Examples/modules/Transition/Types/index.js
@@ -15,7 +15,7 @@ const TransitionTypesExamples = () => (
         <p>Do not unmount a Transition child or else it cannot be animated.</p>
         <Message.List>
           <Message.Item>
-            Use the <code>unmountOnExit</code> prop to unmount the child after the animation exits.
+            Use the <code>unmountOnHide</code> prop to unmount the child after the animation exits.
           </Message.Item>
           <Message.Item>
             Use a <code>Transition.Group</code> to animate children as they mount and unmount.

diff --git a/src/modules/Transition/Transition.d.ts b/src/modules/Transition/Transition.d.ts
@@ -62,7 +62,7 @@ export interface TransitionProps {
   transitionAppear?: boolean;
 
   /** Unmount the component (remove it from the DOM) when it is not shown. */
-  unmountOnExit?: boolean;
+  unmountOnHide?: boolean;
 }
 
 export interface TransitionEventData extends TransitionProps {

diff --git a/src/modules/Transition/Transition.js b/src/modules/Transition/Transition.js
@@ -72,7 +72,7 @@ export default class Transition extends Component {
     transitionAppear: PropTypes.bool,
 
     /** Unmount the component (remove it from the DOM) when it is not shown. */
-    unmountOnExit: PropTypes.bool,
+    unmountOnHide: PropTypes.bool,
   }
 
   static defaultProps = {
@@ -81,7 +81,7 @@ export default class Transition extends Component {
     visible: true,
     mountOnEnter: true,
     transitionAppear: false,
-    unmountOnExit: false,
+    unmountOnHide: false,
   }
 
   static _meta = {
@@ -208,19 +208,19 @@ export default class Transition extends Component {
   }
 
   computeCompletedStatus = () => {
-    const { unmountOnExit } = this.props
+    const { unmountOnHide } = this.props
     const { status } = this.state
 
     if (status === Transition.ENTERING) return Transition.ENTERED
-    return unmountOnExit ? Transition.UNMOUNTED : Transition.EXITED
+    return unmountOnHide ? Transition.UNMOUNTED : Transition.EXITED
   }
 
   computeInitialStatuses = () => {
     const {
       visible,
       mountOnEnter,
       transitionAppear,
-      unmountOnExit,
+      unmountOnHide,
     } = this.props
 
     if (visible) {
@@ -233,7 +233,7 @@ export default class Transition extends Component {
       return { initial: Transition.ENTERED }
     }
 
-    if (mountOnEnter || unmountOnExit) return { initial: Transition.UNMOUNTED }
+    if (mountOnEnter || unmountOnHide) return { initial: Transition.UNMOUNTED }
     return { initial: Transition.EXITED }
   }
 

diff --git a/test/specs/modules/Transition/Transition-test.js b/test/specs/modules/Transition/Transition-test.js
@@ -148,7 +148,7 @@ describe('Transition', () => {
         <Transition
           into={false}
           mountOnEnter={false}
-          unmountOnExit={false}
+          unmountOnHide={false}
         >
           <p />
         </Transition>
@@ -370,7 +370,7 @@ describe('Transition', () => {
     })
   })
 
-  describe('unmountOnExit', () => {
+  describe('unmountOnHide', () => {
     it('unmounts child when true', done => {
       const onHide = () => {
         wrapper.should.have.state('status', Transition.UNMOUNTED)
@@ -382,7 +382,7 @@ describe('Transition', () => {
           duration={0}
           onHide={onHide}
           transitionAppear={false}
-          unmountOnExit
+          unmountOnHide
         >
           <p />
         </Transition>
@@ -401,7 +401,7 @@ describe('Transition', () => {
           duration={5}
           onHide={onHide}
           transitionAppear={false}
-          unmountOnExit={false}
+          unmountOnHide={false}
         >
           <p />
         </Transition>