Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript compile errors #1621

Closed
levithomason opened this issue Apr 24, 2017 · 7 comments
Closed

TypeScript compile errors #1621

levithomason opened this issue Apr 24, 2017 · 7 comments
Labels

Comments

@levithomason
Copy link
Member

levithomason commented Apr 24, 2017

The latest bug fix broke further typings. Ref #1612.

https://cloud.githubusercontent.com/assets/11244106/25345192/b18c5924-2914-11e7-99e9-43ed3ad15da5.png

@mihai-dinculescu
Copy link
Member

Yep, I get the same errors.

@layershifter
Copy link
Member

@levithomason Working on a new PR

@layershifter
Copy link
Member

I've opened #1624, however, we still need rendering tests there

@noah79
Copy link

noah79 commented Apr 26, 2017

Same.

@layershifter
Copy link
Member

@levithomason There is #1624 and #1625 that adds new tests that validate typings. We need your attention.

@vcardins
Copy link

vcardins commented May 2, 2017

Not ideal, but for the time being I hacked by doing this:

loaders: ['react-hot-loader/webpack', `awesome-typescript-loader?${JSON.stringify({ignoreDiagnostics:[2320, 2307]})}`],

@tomitrescak
Copy link
Contributor

Thanks for the hard work! Looking forward to the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants