Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(typings): additional tests for typings and fixes #1624

Merged
merged 3 commits into from
May 6, 2017
Merged

test(typings): additional tests for typings and fixes #1624

merged 3 commits into from
May 6, 2017

Conversation

layershifter
Copy link
Member

Ref #1621

This PR adds two features:

  • adds test for [key: string]: any; signature in ComponentProps
  • adds ignoredProps option, with can skip props from typings (like in FormRadio.d.ts)

Also, fixes known issues and adds tests for Portal and Popup like in a Modal component

@layershifter layershifter mentioned this pull request Apr 24, 2017
Closed
@codecov-io
Copy link

codecov-io commented Apr 24, 2017 •
edited
Loading

Codecov Report

Merging #1624 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1624   +/-   ##
=======================================
  Coverage   99.74%   99.74%           
=======================================
  Files         141      141           
  Lines        2398     2398           
=======================================
  Hits         2392     2392           
  Misses          6        6
Impacted Files Coverage Δ
src/addons/Portal/Portal.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update feb53e0...a720687. Read the comment docs.

@layershifter layershifter mentioned this pull request Apr 24, 2017
Merged
@seryl seryl mentioned this pull request Apr 25, 2017
Closed
@layershifter layershifter mentioned this pull request Apr 25, 2017
Closed
levithomason
levithomason reviewed Apr 28, 2017
View reviewed changes
test/specs/collections/Form/FormFieldCheckbox-test.js Outdated
@@ -5,7 +5,9 @@ import Checkbox from 'src/modules/Checkbox/Checkbox'
import * as common from 'test/specs/commonTests'

describe('FormCheckbox', () => {
common.isConformant(FormCheckbox)
common.isConformant(FormCheckbox, {
ignoredProps: ['type'],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: given that the conformance test covers many things, can we rename this option to specify that it only ignores the prop in typings?

Perhaps ignoreTypingsProps or similar?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's a good suggestion. I will fix it in evening

@levithomason
Copy link
Member

Just one comment regarding the option name.

layershifter
layershifter commented Apr 28, 2017
View reviewed changes
Copy link
Member Author

@layershifter layershifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@levithomason I've updated option name, so I think that we're ready to go 🚌

This was referenced May 1, 2017
Closed
Closed
@levithomason levithomason merged commit 7dc8aff into master May 6, 2017
@levithomason levithomason deleted the test/fix-typings branch May 6, 2017 19:29
@levithomason
Copy link
Member

Released in semantic-ui-react@0.68.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@levithomason levithomason levithomason left review comments

Assignees
No one assigned
Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@layershifter @codecov-io @levithomason