Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: parse {custom} and display correct values #2078

Closed
Maxhodges opened this issue Sep 15, 2017 · 2 comments
Closed

Docs: parse {custom} and display correct values #2078

Maxhodges opened this issue Sep 15, 2017 · 2 comments
Assignees
Labels

Comments

@Maxhodges
Copy link

Maxhodges commented Sep 15, 2017

should list some acceptable values here

only |   | {custom} | A row can appear only for a specific device, or screen sizes.

i get error

ReferenceError: computer is not defined

on <Grid.Column only={computer}>

@layershifter
Copy link
Member

layershifter commented Sep 15, 2017

You're trying to use computer as variable while it's a string value:

<Grid.Column only='computer'>

@layershifter
Copy link
Member

However, our docs plugin should parse all custom values, but it will be not easy. I saw sometime ago on react-docgen and seems they allow to pass custom handlers. Help in this direction is very necessary.

We also need to convert union's to enum's there.

@layershifter layershifter changed the title docs insufficient "only {custom}" Docs: parse {custom} and display correct values Sep 15, 2017
@layershifter layershifter self-assigned this Sep 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants