Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(parser): parse custom values and mixed enums #2086

Merged
merged 2 commits into from
Sep 24, 2017

Conversation

layershifter
Copy link
Member

@layershifter layershifter commented Sep 19, 2017

Fixes #2078.

customPropTypes

before

_999 030
_999 033

after

_999 031
_999 032

mixed enums

before

_999 028

after

image

@codecov-io
Copy link

codecov-io commented Sep 19, 2017

Codecov Report

Merging #2086 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2086   +/-   ##
=======================================
  Coverage   99.76%   99.76%           
=======================================
  Files         149      149           
  Lines        2601     2601           
=======================================
  Hits         2595     2595           
  Misses          6        6
Impacted Files Coverage Δ
src/elements/Flag/Flag.js 87.5% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65ce852...3543724. Read the comment docs.

@levithomason
Copy link
Member

The type in the {bool|enum} case should remain {bool|enum}. The list of enums should show very. The value bool is not a valid enum value, it is a type.

@layershifter
Copy link
Member Author

Thanks for feedback, you're right there. I will fix it tomorrow

@layershifter
Copy link
Member Author

@levithomason I've updated PR as you requested, screenshot in PR header was also updated 👍

@levithomason levithomason merged commit 0fbcd31 into master Sep 24, 2017
@levithomason levithomason deleted the feat/docgen-custom branch September 24, 2017 16:44
@levithomason
Copy link
Member

Great, thanks again!

@levithomason
Copy link
Member

Released in semantic-ui-react@0.74.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants