-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug on Dropdown.componentWillUnmount() #2120
Comments
I have not, but this may be related to #2117. It is being released now as |
@MeXaaR please try the latest release, |
Thanks guys, it work fine now Great fix |
@levithomason I'm still seeing this on
As a workaround I disabled import {
Dropdown as BaseDropdown,
} from 'semantic-ui-react';
class Dropdown extends BaseDropdown {
componentWillUnmount() {
// don't call the buggy code
// See datails at https://github.com/Semantic-Org/Semantic-UI-React/issues/2120
}
} |
Please fill our issue template, we need the reproduction case and its example on the codesandbox. We will reopen the issue once we will have it. |
+1 @layershifter can you work out the issue from the stack trace she provided? Seems like undefined reference kind of thing... |
@mhagmajer Make codepen on sandbox and describe how we can reproduce it. |
@layershifter Despite my best effort, I wasn't able to isolate a clean example of this issue. However, I was able to pin down the bug in code:
The line above causes error if |
What browser is this happening in? I'm unable to reproduce the issue. We also have passing tests that remove handlers multiple times. This covers removing
Not in this case, the error occurs in Without a reproduction case, we cannot tell why this is happening. The proposed PR will only prevent the above workflows, removing an Please submit a reproduction and we can help. |
Simple bug on every component dependants on Dropdown (FormSelect, Select, etc...)
it happens since the last update
anybody has the same issue ?
The text was updated successfully, but these errors were encountered: