-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(eventPool): check existance of handler in EventTarget._unlisten #2246
Conversation
Failing check seems like false negative |
@levithomason I've marked this as ready for review, however I'm not sure that this is fixes something. We don't have reproduction and I don't see how this can be covered by unit tests. |
Codecov Report
@@ Coverage Diff @@
## master #2246 +/- ##
=======================================
Coverage 99.73% 99.73%
=======================================
Files 151 151
Lines 2624 2624
=======================================
Hits 2617 2617
Misses 7 7 Continue to review full report at Codecov.
|
As I've shown here #2120 (comment), both our code and the browser's native code already gracefully handle removing |
I should note, I spent 20-30 minutes researching and also trying to reproduce this. I could not do so in Chrome nor PhantomJS no matter what abuse I threw at our EventTarget and eventStack. I was also unabled to reproduce this in Chrome with The closest I could find was this angular/zone.js#21 issue. They had this error, but they also seemed unable to reproduce it. It seemed to resolve itself, unfortunately. Lastly, neither |
Any more progress on this one? |
Not yet, I'll get back to you when I have something
…On Sun, Nov 5, 2017, 00:47 Levi Thomason ***@***.***> wrote:
Any more progress on this one?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2246 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACmsIqp-_Npy3uihJ_39_tCZeEUaQSzHks5szPd-gaJpZM4QEIMT>
.
|
Closing for housekeeping. Will be reopened if we will have a repro case. |
Fixes #2120