-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modal: scrolling issue when using sub-modals #2248
Comments
Thanks for detailed report 👍 Help is much appreciated there |
I think I have found what is going on: when opening the sub-modal, the "scrolling" class is removed from the body element. It is not added back when the sub-modal is closed. My understanding is that this is done here: Semantic-UI-React/src/modules/Modal/Modal.js Line 262 in 9904616
As the second modal does not know about the first, the second modal removes the "scrolling" class, even though it should not have done so. |
Seems to already have been talked about (but not fixed) in #1157. There's already a workaround solution there, for anybody interested. |
I've incorporated the workaround into a PR. Feedback? |
Is it fixed ? or not yet ? |
Could someone please fix this issue. It is causing alot of mess in my project right now |
@Zacele It is already fixed but not merged yet. There are 24 pull requests still waiting for approve.
|
@Zacele @nzhtrtlc @RetroCraft Please have a look at #2394. |
✔ BUGS → This form is required:
I have a modal that invokes a modal, and this blocs scrolling in the first modal.
Here is how to reproduce:
Steps
Expected Result
You can access the button row by scrolling.
Actual Result
Scrolling does not work.
Version
0.75.1
Testcase
The text was updated successfully, but these errors were encountered: