feat(Input): add focus() method #1477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levithomason
commented
Mar 18, 2017
| @@ -129,7 +129,7 @@ class ComponentExample extends Component { | |||
| } | |||
|
|
|||
| copyJSX = () => { | |||
| copyToClipboard(this.getOriginalSourceCode()) | |||
| copyToClipboard(this.state.sourceCode) | |||
There was a problem hiding this comment.
Bug fix, an example's copy button was copying the original source code. This update makes it copy the current state of the editor.
levithomason
force-pushed
the
feat/input-focus
branch
2 times, most recently
from
38de9e9
to
95c0a7e
Compare
Codecov Report
@@ Coverage Diff @@
## master #1477 +/- ##
==========================================
+ Coverage 99.74% 99.74% +<.01%
==========================================
Files 141 141
Lines 2368 2371 +3
==========================================
+ Hits 2362 2365 +3
Misses 6 6
Continue to review full report at Codecov.
|
levithomason
commented
Mar 18, 2017
| @@ -34,10 +34,10 @@ ButtonOr.propTypes = { | |||
| className: PropTypes.string, | |||
|
|
|||
| /** Or buttons can have their text localized, or adjusted by using the text prop. */ | |||
| text: PropTypes.oneOfType( | |||
| text: PropTypes.oneOfType([ | |||
There was a problem hiding this comment.
Fixed a bad propType argument.
levithomason
force-pushed
the
feat/input-focus
branch
from
95c0a7e
to
6efe8a3
Compare
|
Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1475
A
refon a composite component (like the Input) will return a reference to the class instance. This PR adds a focus method to the Input that focuses the HTML input. This allows users to callfocus()on the Input ref and it will focus the internal HTML input element.An example and test was also added.