Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(MenuExampleNameProp): fix activeItem logic #1585

Merged
merged 1 commit into from
Apr 16, 2017

Conversation

levithomason
Copy link
Member

@levithomason levithomason commented Apr 16, 2017

Fixes #1583

The activeItem comparison logic is using the wrong casing.

@codecov-io
Copy link

codecov-io commented Apr 16, 2017

Codecov Report

Merging #1585 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1585   +/-   ##
=======================================
  Coverage   99.74%   99.74%           
=======================================
  Files         141      141           
  Lines        2381     2381           
=======================================
  Hits         2375     2375           
  Misses          6        6

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f76a03d...708ea4f. Read the comment docs.

@levithomason levithomason merged commit 495ac52 into master Apr 16, 2017
@levithomason levithomason deleted the fix/menu-example-name-prop branch April 16, 2017 17:01
@levithomason
Copy link
Member Author

Released in semantic-ui-react@0.68.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants