test(typings): initial tests for typings #1611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
commented
Apr 23, 2017
| @@ -64,7 +64,7 @@ export { default as Flag, FlagProps } from './dist/commonjs/elements/Flag' | |||
|
|
|||
| export { default as Header, HeaderProps } from './dist/commonjs/elements/Header' | |||
| export { default as HeaderContent, HeaderContentProps } from './dist/commonjs/elements/Header/HeaderContent' | |||
| export { default as HeaderSubheader, HeaderSubHeaderProps } from './dist/commonjs/elements/Header/HeaderSubheader' | |||
| export { default as HeaderSubheader, HeaderSubheaderProps } from './dist/commonjs/elements/Header/HeaderSubheader' | |||
There was a problem hiding this comment.
Fixed interface name
layershifter
commented
Apr 23, 2017
| @@ -15,6 +15,9 @@ export interface BreadcrumbSectionProps { | |||
| /** Additional classes. */ | |||
| className?: string; | |||
|
|
|||
| /** Shorthand for primary content. */ | |||
| content?: any; | |||
|
|
|||
Codecov Report
@@ Coverage Diff @@
## master #1611 +/- ##
=======================================
Coverage 99.74% 99.74%
=======================================
Files 141 141
Lines 2398 2398
=======================================
Hits 2392 2392
Misses 6 6
Continue to review full report at Codecov.
|
This was referenced Apr 24, 2017
| @@ -45,6 +45,8 @@ describe('Modal', () => { | |||
| }) | |||
|
|
|||
| common.hasSubComponents(Modal, [ModalHeader, ModalContent, ModalActions, ModalDescription]) | |||
| common.hasValidTypings(Modal) | |||
There was a problem hiding this comment.
Looks like this might already be covered by the common.isConformant() test, true?
There was a problem hiding this comment.
Modal-test.js doesn't contain isConformant test
|
Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have constant problems with typings (#1609 and more), it's time to solve them ✌️
This PR replaces #1181 and offers initial tests for typings. What it does:
Component.d.tsexists for each component;ComponentPropsinterface and it's exported;Component.propTypesand props that are required in definitions are really required.Also, it fixes all found problems 🥂 Our typiscript users will be satisfied 👍