docs(props): fix uniqueness #1780
Conversation
gulp/plugins/util/parseType.js
Outdated
| const evalValue = value => _.uniq(eval(value)) // eslint-disable-line no-eval | ||
| const evalValue = value => eval(value) // eslint-disable-line no-eval | ||
|
|
||
| const uniqValues = values => _.uniqWith(values, (val, other) => val == other) // eslint-disable-line eqeqeq |
There was a problem hiding this comment.
We cannot use there strict equals, because 1 and '1' aren't equal.
There was a problem hiding this comment.
Coerce them both to numbers with the + operator:
+val === +otherExample:
val = '5'
typeof val // => "string"
typeof +val // => "number"
val === 5 // => false
+val === 5 // => trueThere was a problem hiding this comment.
Yes, but not all items of array are numbers:
val = 'five'
+val // => NaNThere was a problem hiding this comment.
I think we can do following:
`${val}` === `${other}`
// or
val.toString() === other.toString()There was a problem hiding this comment.
Nice catch, that works as well.
Codecov Report
@@ Coverage Diff @@
## master #1780 +/- ##
=======================================
Coverage 99.75% 99.75%
=======================================
Files 142 142
Lines 2459 2459
=======================================
Hits 2453 2453
Misses 6 6Continue to review full report at Codecov.
|
|
Thank ya! |
|
Released in |
Before
After
Why?
SUI.WIDTHScontains both numbers and strings (example:1and'1'), but it does not matter for the docs. Also, as we usevalueaskeyand React convertskeyto string, we have duplicate, but invisible elements.