style(typings): Add tab panes prop definition #1812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierre-H
changed the title
So this interface can be used in code
Codecov Report
@@ Coverage Diff @@
## master #1812 +/- ##
=======================================
Coverage 99.75% 99.75%
=======================================
Files 144 144
Lines 2463 2463
=======================================
Hits 2457 2457
Misses 6 6Continue to review full report at Codecov.
|
layershifter
requested changes
Jun 30, 2017
src/modules/Tab/Tab.d.ts
Outdated
| @@ -27,7 +27,7 @@ export interface TabProps { | |||
| onTabChange?: (event: React.MouseEvent<HTMLDivElement>, data: TabProps) => void; | |||
|
|
|||
| /** Shorthand props for the Menu. */ | |||
| panes?: any; | |||
| panes?: Array<{menuItem: string; render: () => React.ReactNode;}>; | |||
There was a problem hiding this comment.
Can we make it multiline?
panes?: Array<{
menuItem: string;
render: () => React.ReactNode;
}>;There was a problem hiding this comment.
@layershifter done
|
I've relaxed type for changes from #1823. |
|
Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.