-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style(typings): Add tab panes prop definition #1812
Conversation
So this interface can be used in code
Codecov Report
@@ Coverage Diff @@
## master #1812 +/- ##
=======================================
Coverage 99.75% 99.75%
=======================================
Files 144 144
Lines 2463 2463
=======================================
Hits 2457 2457
Misses 6 6 Continue to review full report at Codecov.
|
src/modules/Tab/Tab.d.ts
Outdated
@@ -27,7 +27,7 @@ export interface TabProps { | |||
onTabChange?: (event: React.MouseEvent<HTMLDivElement>, data: TabProps) => void; | |||
|
|||
/** Shorthand props for the Menu. */ | |||
panes?: any; | |||
panes?: Array<{menuItem: string; render: () => React.ReactNode;}>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we make it multiline?
panes?: Array<{
menuItem: string;
render: () => React.ReactNode;
}>;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@layershifter done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pierre-H Thanks again, LGTM
I've relaxed type for changes from #1823. |
Released in |
No description provided.