Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(AutoControlledComponent): rename state method #1865

Merged
merged 1 commit into from
Jul 16, 2017

Conversation

layershifter
Copy link
Member

Fixes #1863.

In #1799 we improved compatibility with React 16, that PR introcuced getInitialState method as was suggested. However, this name is reserved and produces warnings even in Fiber.

@codecov-io
Copy link

codecov-io commented Jul 14, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@931fe37). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1865   +/-   ##
=========================================
  Coverage          ?   99.75%           
=========================================
  Files             ?      145           
  Lines             ?     2474           
  Branches          ?        0           
=========================================
  Hits              ?     2468           
  Misses            ?        6           
  Partials          ?        0
Impacted Files Coverage Δ
src/modules/Tab/Tab.js 100% <ø> (ø)
src/modules/Accordion/Accordion.js 100% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 931fe37...f1dfd47. Read the comment docs.

@levithomason
Copy link
Member

levithomason commented Jul 16, 2017

For parity with our autoControlledProps and React's getInitialState I went with getInitialAutoControlledState .

@levithomason levithomason merged commit 93deaa9 into master Jul 16, 2017
@levithomason levithomason deleted the fix/initial-state branch July 16, 2017 22:01
@levithomason levithomason changed the title fix(AutoControlledComponent): rename state method breaking(AutoControlledComponent): rename state method Jul 16, 2017
@levithomason levithomason changed the title breaking(AutoControlledComponent): rename state method fix(AutoControlledComponent): rename state method Jul 16, 2017
@levithomason
Copy link
Member

Released in semantic-ui-react@0.71.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants