-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Tab): add renderActiveOnly
prop
#1976
Conversation
169a882
to
a2b4a24
Compare
Codecov Report
@@ Coverage Diff @@
## master #1976 +/- ##
=========================================
+ Coverage 99.8% 99.8% +<.01%
=========================================
Files 148 148
Lines 2589 2590 +1
=========================================
+ Hits 2584 2585 +1
Misses 5 5
Continue to review full report at Codecov.
|
a2b4a24
to
49b2199
Compare
Has merge conflicts |
…React into feat/tab-render # Conflicts: # src/modules/Tab/Tab.js
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Solved merge conflict and merged with master
, ready for review
Released in |
Fyi, this change does not work. Setting |
We should make it so. |
Thanks for pointing out those examples. They worked. I'm still having trouble with the example that the OP in #1877 provides of Leaflet, but perhaps this is a Leaflet issue. |
Fixes #1877.