Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Button|Menu|List|Step): fix behaviour of onClick when is disabled #2006

Merged
merged 1 commit into from
Aug 27, 2017

Conversation

layershifter
Copy link
Member

Fixes #1964.

Affects:

  • Button
  • ListItem
  • MenuItem
  • Step

We have disabled prop also in:

  • FormField - I don't touch because it doesn't have onClick handler and I'm not sure that it will be correct behaviour
  • TableCell/TableRow - I think we can update the behaviour there, but these components don't have onClick handler
  • Icon, Image, Loader, Reveal, Segment, Progress - These components don't have onClick handler and I'm not sure that we need to change there something
    Checkbox, Dropdown, Rating - already handles disabled
    Dimmer - disabled has there another context

@codecov-io
Copy link

codecov-io commented Aug 25, 2017

Codecov Report

Merging #2006 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2006   +/-   ##
======================================
  Coverage    99.8%   99.8%           
======================================
  Files         148     148           
  Lines        2589    2589           
======================================
  Hits         2584    2584           
  Misses          5       5
Impacted Files Coverage Δ
src/collections/Menu/MenuItem.js 100% <100%> (ø) ⬆️
src/elements/List/ListItem.js 100% <100%> (ø) ⬆️
src/elements/Step/Step.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23ec465...0f111c3. Read the comment docs.

@levithomason
Copy link
Member

Let's merge this as it is a great step forward.

We may need to double back and add onClick handlers for the others you've mentioned, but let's see what the community response is before investing the time. Also, the CSS for many disabled classes includes pointer-events: none which effectively does the same thing.

@levithomason levithomason merged commit e372781 into master Aug 27, 2017
@levithomason levithomason deleted the fix/handle-disabled branch August 28, 2017 00:49
@levithomason
Copy link
Member

Released in semantic-ui-react@0.72.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants