fix(Modal): add/remove dimmer classes in raf #2010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 28, 2017
|
Super excited for this PR to be merged so I can remove all the |
levithomason
force-pushed
the
fix/modal-dimmer-classes
branch
from
159eb92
to
296d8b6
Compare
Codecov Report
@@ Coverage Diff @@
## master #2010 +/- ##
==========================================
- Coverage 99.76% 99.76% -0.01%
==========================================
Files 151 151
Lines 2605 2602 -3
==========================================
- Hits 2599 2596 -3
Misses 6 6
Continue to review full report at Codecov.
|
|
I've fixed tests/lint and rebased to master. We're good to go here once tests pass. |
|
Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1157
The dimmer classes added to and removed from the
bodycurrently only happen on mount and unmount. However, with multiple modals, the outer most Modal's unmount will remove the classes and the Modal beneath it will appear broken.This PR moves the dimmer body class handling to the animation frame, beside the
scrollingclass handling. This way, the dimmer classes are continually updated.