Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(Flag|Icon): add shouldComponentUpdate with shallowEqual #2011

Merged
merged 1 commit into from
Aug 28, 2017

Conversation

layershifter
Copy link
Member

@layershifter layershifter commented Aug 28, 2017

Rel #1020.

I've imported shallowEqual in #1981 and remembered about #1020. Converts Flag and Icon to class components and adds shouldComponentUpdate with shallowEqual.

@codecov-io
Copy link

codecov-io commented Aug 28, 2017

Codecov Report

Merging #2011 into master will decrease coverage by 0.03%.
The diff coverage is 91.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2011      +/-   ##
==========================================
- Coverage    99.8%   99.76%   -0.04%     
==========================================
  Files         148      148              
  Lines        2561     2556       -5     
==========================================
- Hits         2556     2550       -6     
- Misses          5        6       +1
Impacted Files Coverage Δ
src/elements/Icon/Icon.js 100% <100%> (ø) ⬆️
src/elements/Flag/Flag.js 87.5% <83.33%> (-12.5%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b60e2aa...3e96cc3. Read the comment docs.

@levithomason levithomason merged commit e1ff28a into master Aug 28, 2017
@levithomason levithomason deleted the perf/icon-flag branch August 28, 2017 09:28
@levithomason
Copy link
Member

Released in semantic-ui-react@0.73.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants