Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tests): replace phantomjs with chromium #2024

Merged
merged 1 commit into from
Sep 1, 2017
Merged

Conversation

layershifter
Copy link
Member

@layershifter layershifter commented Aug 30, 2017

Why?

Chrome teams released an awesome puppeteer, the main advantage is that it installs headless Chromium. So, we can use it in CI without any problems. This PR replaces phantomjs, there are maintaining problems while we need more features.

Advantages

@codecov-io
Copy link

codecov-io commented Aug 30, 2017

Codecov Report

Merging #2024 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2024   +/-   ##
=======================================
  Coverage   99.76%   99.76%           
=======================================
  Files         148      148           
  Lines        2556     2556           
=======================================
  Hits         2550     2550           
  Misses          6        6

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1ff28a...ce2c1aa. Read the comment docs.

@levithomason
Copy link
Member

Awesome! LGTM.

@levithomason levithomason merged commit ef9faee into master Sep 1, 2017
@levithomason levithomason deleted the chore/runner branch September 1, 2017 03:40
@levithomason
Copy link
Member

Released in semantic-ui-react@0.73.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants