Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Dropdown): fix call order of onAddItem and onChange handlers #2113

Merged
merged 2 commits into from
Sep 24, 2017

Conversation

layershifter
Copy link
Member

Fixes #2106.

@codecov-io
Copy link

codecov-io commented Sep 24, 2017

Codecov Report

Merging #2113 into master will increase coverage by 14.79%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #2113       +/-   ##
===========================================
+ Coverage   84.97%   99.76%   +14.79%     
===========================================
  Files         150      150               
  Lines        2596     2596               
===========================================
+ Hits         2206     2590      +384     
+ Misses        390        6      -384
Impacted Files Coverage Δ
src/modules/Dropdown/Dropdown.js 100% <100%> (ø) ⬆️
src/modules/Modal/Modal.js 100% <0%> (+3.94%) ⬆️
src/modules/Progress/Progress.js 100% <0%> (+4.76%) ⬆️
src/modules/Tab/Tab.js 100% <0%> (+10.52%) ⬆️
src/views/Card/Card.js 100% <0%> (+20%) ⬆️
src/modules/Sticky/Sticky.js 100% <0%> (+31.64%) ⬆️
src/modules/Transition/Transition.js 100% <0%> (+53.42%) ⬆️
src/modules/Modal/ModalHeader.js 100% <0%> (+62.5%) ⬆️
src/modules/Popup/PopupHeader.js 100% <0%> (+62.5%) ⬆️
src/modules/Popup/PopupContent.js 100% <0%> (+62.5%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f250dc6...76973d4. Read the comment docs.

@levithomason levithomason merged commit d9747ab into master Sep 24, 2017
@levithomason levithomason deleted the fix/dropdown-handlers branch September 24, 2017 17:25
@levithomason
Copy link
Member

Released in semantic-ui-react@0.74.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants