Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(common): support isConformant for portals #2146

Merged
merged 5 commits into from
Sep 30, 2017

Conversation

levithomason
Copy link
Member

@levithomason levithomason commented Sep 30, 2017

These commits were cherry picked from Datetime #1240. We need to be able to test conformance for components that render portals.

  • Add a rendersPortal isConformant option.
  • Skip as prop conformance tests, not idea but better than skipping all conformance tests as we do now. Portals render other components, which handle the as prop anyway.
  • Look for the user's className in the document.body if rendering a portal.

@codecov-io
Copy link

Codecov Report

Merging #2146 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2146   +/-   ##
=======================================
  Coverage   99.76%   99.76%           
=======================================
  Files         150      150           
  Lines        2601     2601           
=======================================
  Hits         2595     2595           
  Misses          6        6
Impacted Files Coverage Δ
src/modules/Popup/Popup.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 943bf13...499432f. Read the comment docs.

@levithomason
Copy link
Member Author

Released in semantic-ui-react@0.75.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants