Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Modal): set scrolling body class on re-open #2152

Merged
merged 1 commit into from
Oct 10, 2017

Conversation

ayastreb
Copy link
Contributor

@ayastreb ayastreb commented Oct 2, 2017

Fixes #2150 by unsetting scrolling state prop when modal is closed.

@codecov-io
Copy link

Codecov Report

Merging #2152 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2152   +/-   ##
=======================================
  Coverage   99.76%   99.76%           
=======================================
  Files         151      151           
  Lines        2602     2602           
=======================================
  Hits         2596     2596           
  Misses          6        6
Impacted Files Coverage Δ
src/modules/Modal/Modal.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c97ed9...463b232. Read the comment docs.

@lewisblackwood
Copy link
Contributor

@layershifter could this PR be reviewed and merged? Would help resolve a bug in our project when scrolling modal is closed and reopened. Thanks!

@layershifter
Copy link
Member

@lewisblackwood I want to hear the opinion from @levithomason before merge this

@levithomason
Copy link
Member

This is an OK solution to the issue at hand.

We have another problem with Modals and adding/removing body classes. When stacking Modals, closing the second Modal will remove body classes that the first Modal may still need. We'll tackle that on another PR.

@levithomason
Copy link
Member

Released in semantic-ui-react@0.75.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modal: Scrolling doesn't work properly after reopen
5 participants