Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(TextArea): fix autoHeight calculate wrong value on long text #2199

Merged
merged 1 commit into from
Oct 18, 2017

Conversation

WiNloSt
Copy link
Contributor

@WiNloSt WiNloSt commented Oct 16, 2017

Calculate content height without taking a vertical scroll bar into account.

fixes #2173

Calculate content height without taking a vertical scroll bar into
account.
@WiNloSt
Copy link
Contributor Author

WiNloSt commented Oct 16, 2017

Tests failed at

adds/removes body classes "dimmable dimmed" on mount/unmount
HeadlessChrome 0.0.0 (Linux 0.0.0)
AssertionError: document.body should not have class "dimmable", but it has class="dimmable dimmed": expected true to equal false

Not sure if it has anything to do with my code, but tests passes on my machine.

@codecov-io
Copy link

codecov-io commented Oct 17, 2017

Codecov Report

Merging #2199 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2199      +/-   ##
==========================================
+ Coverage   99.73%   99.73%   +<.01%     
==========================================
  Files         151      151              
  Lines        2622     2624       +2     
==========================================
+ Hits         2615     2617       +2     
  Misses          7        7
Impacted Files Coverage Δ
src/addons/TextArea/TextArea.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3cfece0...521fa7c. Read the comment docs.

@layershifter
Copy link
Member

Retrigger build, now CI passing

@levithomason levithomason merged commit d651ce9 into Semantic-Org:master Oct 18, 2017
@levithomason
Copy link
Member

Thanks folks!

@levithomason
Copy link
Member

Released in semantic-ui-react@0.75.1

@WiNloSt WiNloSt deleted the fix-textarea-auto-height branch October 18, 2017 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TextArea's autoHeight sometimes makes it taller than an actual text
4 participants