Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(Icon): fix similar icon search #2220

Merged
merged 2 commits into from
Oct 20, 2017

Conversation

patrikmolsson
Copy link
Contributor

@patrikmolsson patrikmolsson commented Oct 20, 2017

Fixes #2193.

Addresses the issue described in #2193

Merely tested on fork's deployed site: https://patrikmolsson.github.io/Semantic-UI-React/.

@codecov-io
Copy link

Codecov Report

Merging #2220 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2220      +/-   ##
==========================================
- Coverage   99.73%   99.73%   -0.01%     
==========================================
  Files         151      151              
  Lines        2624     2611      -13     
==========================================
- Hits         2617     2604      -13     
  Misses          7        7
Impacted Files Coverage Δ
src/elements/Divider/Divider.js 100% <0%> (ø) ⬆️
src/collections/Menu/MenuMenu.js 100% <0%> (ø) ⬆️
src/collections/Message/MessageContent.js 100% <0%> (ø) ⬆️
src/modules/Search/SearchResults.js 100% <0%> (ø) ⬆️
src/collections/Form/FormField.js 100% <0%> (ø) ⬆️
src/elements/Rail/Rail.js 100% <0%> (ø) ⬆️
src/views/Comment/CommentAuthor.js 100% <0%> (ø) ⬆️
src/modules/Popup/PopupContent.js 100% <0%> (ø) ⬆️
src/views/Card/CardContent.js 100% <0%> (ø) ⬆️
src/modules/Search/SearchResult.js 100% <0%> (ø) ⬆️
... and 44 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20e9a63...dac4312. Read the comment docs.

Copy link
Member

@layershifter layershifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@patrickgaskill Awesome work 👍 Thanks for finishing it

@layershifter layershifter merged commit 4f29636 into Semantic-Org:master Oct 20, 2017
@patrikmolsson patrikmolsson deleted the docs/icon-search branch October 20, 2017 19:12
@patrikmolsson
Copy link
Contributor Author

@layershifter Of course :) Just a question, how come the tests were failing?

@layershifter
Copy link
Member

There is a strange bug with one of Modal tests, I can't reproduce it locally. Sometime it fails, sometime - no 🤔

@patrikmolsson
Copy link
Contributor Author

@layershifter Is this the new Modal test? From 0.75?

@layershifter
Copy link
Member

Nope, it fails periodically from 0.74.x as I remember:

FAILED TESTS:
  Modal
    dimmer
      false
        ✖ does not add any dimmer classes to the body
          HeadlessChrome 0.0.0 (Linux 0.0.0)
          AssertionError: document.body should not have class "dimmable", but it has class="dimmable dimmed": expected true to equal false
              at test/utils/assertBodyClasses.js:22:0
              at Array.forEach (<anonymous>)
              at assertBodyClasses (test/utils/assertBodyClasses.js:17:0
              at Context.<anonymous> (test/specs/modules/Modal/Modal-test.js:280:0

@levithomason
Copy link
Member

Released in semantic-ui-react@0.76.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants