breaking(Image): Inconsistent prop usage between Image and Icon for circular shape #2225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
requested changes
Oct 20, 2017
There was a problem hiding this comment.
@RetroCraft Please fix lint errors, yarn run lint:fix
126:1 error Trailing spaces not allowed no-trailing-spaces
138:1 error Trailing spaces not allowed no-trailing-spaces
171:1 error Trailing spaces not allowed no-trailing-spaces
|
@RetroCraft Also this PR should be marked as breaking in title and initial comment. We also need to provide before/after usage example in the initial comment. See #2145 for example. |
RetroCraft
changed the title
Sorry...I'm using github online as I'm out
Codecov Report
@@ Coverage Diff @@
## master #2225 +/- ##
=======================================
Coverage 99.73% 99.73%
=======================================
Files 151 151
Lines 2624 2624
=======================================
Hits 2617 2617
Misses 7 7
Continue to review full report at Codecov.
|
|
I think everything is good now. |
layershifter
approved these changes
Oct 20, 2017
|
Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2217.
Why?
Make properties more concistent with other elements. See #2217 for more details.
Image<Image shape="rounded" /><Image rounded /><Image shape="circular" /><Image circular />