fix(Input): icon should be always after <input> #2302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2302 +/- ##
==========================================
- Coverage 99.73% 99.73% -0.01%
==========================================
Files 152 152
Lines 2656 2655 -1
==========================================
- Hits 2649 2648 -1
Misses 7 7
Continue to review full report at Codecov.
|
|
@levithomason I don't merge this because I don't remember the reasons for different positions. Can you clarify? |
|
The change of position here was strictly for HTML correctness with the prop value (left). However, it appears the CSS rule was overlooked. Your change is acceptable. Someday, inline styles will remove all this CSS hierarchy dependency. Long live that day! |
|
Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2298.