-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Pagination): add new component #2352
Conversation
…React into feat/pagination
@levithomason I'll be glad to hear your opinion there 😄 |
c471c55
to
c91dedb
Compare
Codecov Report
@@ Coverage Diff @@
## master #2352 +/- ##
==========================================
+ Coverage 99.73% 99.73% +<.01%
==========================================
Files 152 154 +2
Lines 2664 2680 +16
==========================================
+ Hits 2657 2673 +16
Misses 7 7
Continue to review full report at Codecov.
|
This is so cool and much needed! Here are my initial thoughts when trying the component. showFirstAndLastI would expect this prop to show the first and last page number in the list of pages. However, that is already shown. This prop seems to add first and last navigation buttons but those are duplicating the first and last page number buttons: 💡 Suggestion: Perhaps split this into showPreviousAndNextSince the item prop is Item shorthandI can't seem to turn off the first/last page number. Passing <Pagination firstItem={null} lastItem={false} /> Oh, right. You'd pass |
fb480ad
to
18dd654
Compare
@levithomason I've applied proposed changes and removed all boolean |
Cool, great first implementation! |
Released in |
This PR adds the fully featured pagination to SUIR using existing Menu component.