fix(TransionablePortal): fix state handling #2390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
commented
Dec 19, 2017
| // But, when it's autocontrolled we should change the state to opposite to keep the transition | ||
| // queue | ||
| if (_.isNil(open)) this.setState({ portalOpen: !portalOpen }) | ||
| this.setState({ portalOpen: false }) |
There was a problem hiding this comment.
I rethought the state handling there and as I see, it was overcomplicated. I've simplified it and it looks that everything is correct.
layershifter
commented
Dec 19, 2017
|
|
||
| // Heads up! We simply call `onClose` when component is controlled with `open` prop. |
There was a problem hiding this comment.
Cruft, we don't call onClose and it seems that condition below doesn't make sence.
Codecov Report
@@ Coverage Diff @@
## master #2390 +/- ##
==========================================
- Coverage 99.73% 99.73% -0.01%
==========================================
Files 152 152
Lines 2664 2662 -2
==========================================
- Hits 2657 2655 -2
Misses 7 7
Continue to review full report at Codecov.
|
|
Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2382.