Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(layouts): make HomepageLayout responsive #2396

Merged
merged 1 commit into from
Jan 31, 2018
Merged

Conversation

layershifter
Copy link
Member

Fixes: #2386

@layershifter
Copy link
Member Author

@brianespinosa Your feedback is much needed there

@codecov-io
Copy link

Codecov Report

Merging #2396 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2396   +/-   ##
=======================================
  Coverage   99.73%   99.73%           
=======================================
  Files         152      152           
  Lines        2664     2664           
=======================================
  Hits         2657     2657           
  Misses          7        7

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f2f3fc...9b06660. Read the comment docs.

@brianespinosa
Copy link
Member

@layershifter just getting back from the holidays. I just assigned this to myself and will take a deeper look later this afternoon. 👍

@dongcai
Copy link

dongcai commented Jan 11, 2018

@layershifter & @brianespinosa I think this solution breaks the Server Side Rendering. I actually tried to do the similar thing at: https://github.com/dongcai/react-redux-semantic-ui/blob/master/src/components/Navigation/Navigation.js
And found that the code like <responsive>{children}</responsive> will break the SSR, which I would like {chidren} to be rendered by. Any ideas?

@layershifter
Copy link
Member Author

@dongcai please make a minimal repro repo and open new issue.

@brianespinosa
Copy link
Member

@layershifter Sorry... my workload exploded this month. I haven't even been on github in two weeks. I will try to get some eyes on this by Monday. Apologies for the delay.

@layershifter layershifter merged commit 7f4d7e3 into master Jan 31, 2018
@layershifter layershifter deleted the docs/home-layout branch January 31, 2018 18:56
@layershifter
Copy link
Member Author

Merged as is, we can always to fix it in future 👍

@brianespinosa
Copy link
Member

Thanks @layershifter

Additionally... I meant to bring this up here and with @levithomason , it might be good to update the layout of the docs in general to make the side menu available to toggle on/off. Maybe just update the style of the docs in general in preparation for 1.0.

But I think this looks good for now. 👍

@levithomason
Copy link
Member

Definitely agree. We should use the actual Sidebar component. I think it needs #1408 before that can be done properly.

@levithomason
Copy link
Member

Released in semantic-ui-react@v0.78.0.

Brantron pushed a commit to Brantron/Semantic-UI-React that referenced this pull request Mar 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants