Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(icon): Adding missing cog icon alias, fix SUI.js #2766

Closed
wants to merge 2 commits into from
Closed

feat(icon): Adding missing cog icon alias, fix SUI.js #2766

wants to merge 2 commits into from

Conversation

srbala
Copy link

@srbala srbala commented May 6, 2018

Cog icon (alias of single gear) is missing in current list

Cog icon (alias of single gear) is missing in current list
@welcome
Copy link

welcome bot commented May 6, 2018

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Run yarn lint locally to catch formatting errors. This will fix some errors automatically, commit and push any changes.
  • Run yarn test locally to catch errors. This ensures all components still behave as they should.
  • Run yarn start to run the doc site locally and try a few pages, ensuring everything is in good working order.
  • Include tests when adding/changing behavior.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@codecov-io
Copy link

codecov-io commented May 6, 2018

Codecov Report

Merging #2766 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2766   +/-   ##
=======================================
  Coverage   99.74%   99.74%           
=======================================
  Files         160      160           
  Lines        2762     2762           
=======================================
  Hits         2755     2755           
  Misses          7        7

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed935f8...f827210. Read the comment docs.

@srbala srbala changed the title Update SUI.js, Adding missing cog icon alias feat(icon): Adding missing cog icon alias, fix SUI.js May 6, 2018
@srbala
Copy link
Author

srbala commented May 6, 2018

Just realized that, it may be need SUI 2.3.x

@levithomason
Copy link
Member

Just realized that, it may be need SUI 2.3.x

Yep. This is done in our next branch. Closing as a dupe of #2657.

@srbala srbala deleted the feat/add-cog-icon branch May 6, 2018 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants