Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Datetime): add component #2821

Closed
wants to merge 32 commits into from
Closed

feat(Datetime): add component #2821

wants to merge 32 commits into from

Conversation

levithomason
Copy link
Member

@levithomason levithomason commented May 21, 2018

Ported to our repo from #1240. This allows us to more easily manage the work and merge in contributors' PRs.


(From original PR)

This is a work in progress mainly focused on exploring the possiblity of adding a datetime component which supports date ranges, time and localisation.

TODO

Bugs and Features

  • allow typing/pasting dates into the input field
  • do not show completely disabled weeks in month view
  • Menu needs some work, buttons don't make sense in all states
  • Expose ways to customize the menu and table as well
  • Add some more props for configuring the view and doc examples
    • showWeekends
    • showDaysOfWeek
  • if at all possible, remove inline styles. required styles should be configurable.
  • move to 5 button CalendarMenu: << < Mo, Yr > >>. double chevrons change year, single change month, mo
  • don't allow selecting invalid ranges: start > end
  • use 12hr time grid with AM/PM option
  • provide onChange callbacks with (e, { value }) where value is the proposed new value.
  • Add dateSeparator prop to DateRange to control the separator string between the two dates

Docs

  • document function prop signatures
  • change Week starts Sunday example to First Day Of Week show two examples, start on Sun, another on Monday.
  • fix disabled days example, do not import date utils

Cleanup

  • move component to /addons
  • remove cruft propTypes that do not exist
  • sort propTypes alphabetically
  • update Month.js to use DateTimeGrid, feat(datetime): Add component #1240 (comment)
  • complete all code TODOs in /Datetime
  • reverse onDateSelect args to match other callbacks, with event first.
  • remove unused methods in classes

@levithomason levithomason mentioned this pull request May 21, 2018
23 tasks
* fix (Datetime): fix calendar next/prev navigation

* fix (Datetime): fix truncation of days in a calendar month

* fix (Datetime): calendar navigation when mode is set to hour

* fix (DatetimeHours): display hours pop-up for selecting time

* fix (Datetime): change mode when user clicks month or year on DatetimeMenu

* fix (DatetimeMinutes): display calendar pop-up with minutes

* fix (Datetime): calendar prev/next navigation when mode is set to minute
@stale
Copy link

stale bot commented Nov 28, 2018

There has been no activity in this thread for 180 days. While we care about every issue and we’d love to see this fixed, the core team’s time is limited so we have to focus our attention on the issues that are most pressing. Therefore, we will likely not be able to get to this one.

However, PRs for this issue will of course be accepted and welcome!

If there is no more activity in the next 180 days, this issue will be closed automatically for housekeeping. To prevent this, simply leave a reply here. Thanks!

@stale stale bot added the stale label Nov 28, 2018
* feat(Datetime): add AM/PM options

* fix(Datetime): Display AM/PM alongside each hour for 12-hour format
@stale stale bot removed the stale label Dec 9, 2018
@stale
Copy link

stale bot commented Jun 7, 2019

There has been no activity in this thread for 180 days. While we care about every issue and we’d love to see this fixed, the core team’s time is limited so we have to focus our attention on the issues that are most pressing. Therefore, we will likely not be able to get to this one.

However, PRs for this issue will of course be accepted and welcome!

If there is no more activity in the next 180 days, this issue will be closed automatically for housekeeping. To prevent this, simply leave a reply here. Thanks!

@stale stale bot added the stale label Jun 7, 2019
@layershifter
Copy link
Member

Closing for housekeeping, I don't believe that this work will be ever done.

I recommend to use https://github.com/arfedulov/semantic-ui-calendar-react right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants