Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(package): use react 16.4 in docs and tests #3068

Merged
merged 3 commits into from
Aug 6, 2018

Conversation

layershifter
Copy link
Member

@layershifter layershifter commented Aug 6, 2018

Needed by #3032.

Oleksandr Fediashov added 2 commits August 6, 2018 14:19
Signed-off-by: Oleksandr Fediashov <ofediashov@exadel.com>
Signed-off-by: Oleksandr Fediashov <ofediashov@exadel.com>
@layershifter
Copy link
Member Author

In both cases we have a strange issue, spies are called twice. However I tested this manually, in real env they are called once 🤔

I fixed this tests to pass.

@codecov-io
Copy link

Codecov Report

Merging #3068 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3068      +/-   ##
==========================================
- Coverage   99.96%   99.92%   -0.04%     
==========================================
  Files         163      163              
  Lines        2738     2738              
==========================================
- Hits         2737     2736       -1     
- Misses          1        2       +1
Impacted Files Coverage Δ
src/modules/Dropdown/Dropdown.js 99.75% <0%> (-0.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1292121...3f90fa4. Read the comment docs.

@layershifter layershifter merged commit cd29a3a into master Aug 6, 2018
@layershifter layershifter deleted the chore/react-16.4 branch August 6, 2018 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants