fix(Popup): remove logic with setSafeState() #3301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3301 +/- ##
==========================================
- Coverage 99.92% 99.89% -0.04%
==========================================
Files 169 169
Lines 2803 2802 -1
==========================================
- Hits 2801 2799 -2
- Misses 2 3 +1
Continue to review full report at Codecov.
|
layershifter
changed the title
layershifter
force-pushed
the
mixed/fix-state
branch
from
44d69ec to
ec98a17
Compare
| @@ -164,7 +160,7 @@ export default class Popup extends Component { | |||
| } | |||
|
|
|||
| componentWillUnmount() { | |||
| this.mounted = false | |||
| clearTimeout(this.timeoutId) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes useless logic with
setSafeState(), we just need to clear properly intervales and frames.