Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Button) : Add aria-pressed attribute for toggle button #3330

Merged

Conversation

shufflerAbhi
Copy link
Contributor

This adds the aria-pressed attribute for toggle button. #3329

The value of active prop determines the value of aria-pressed when toggle is set. Otherwise aria-pressed is left undefined.

A few test cases have been added to verify functionality.

@welcome
Copy link

welcome bot commented Dec 8, 2018

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Run yarn lint locally to catch formatting errors. This will fix some errors automatically, commit and push any changes.
  • Run yarn test locally to catch errors. This ensures all components still behave as they should.
  • Run yarn start to run the doc site locally and try a few pages, ensuring everything is in good working order.
  • Include tests when adding/changing behavior.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@shufflerAbhi shufflerAbhi changed the title feat(Button) : Add aria-pressed attribute for toggle button #3329 feat(Button) : Add aria-pressed attribute for toggle button Dec 8, 2018
@codecov-io
Copy link

Codecov Report

Merging #3330 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3330   +/-   ##
=======================================
  Coverage   99.89%   99.89%           
=======================================
  Files         170      170           
  Lines        2801     2801           
=======================================
  Hits         2798     2798           
  Misses          3        3
Impacted Files Coverage Δ
src/elements/Button/Button.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93c918b...eeea8b0. Read the comment docs.

@levithomason
Copy link
Member

Awesome, thanks!

@levithomason levithomason merged commit 132e73f into Semantic-Org:master Dec 9, 2018
@welcome
Copy link

welcome bot commented Dec 9, 2018

Congrats on merging your first pull request! 🎉🎉🎉

robot victory dance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants