Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Dropdown): use EventStack component #3428

Merged
merged 4 commits into from
Feb 17, 2019

Conversation

layershifter
Copy link
Member

This PR continues work to use EventStack as a component.
The goal: to have declarative API there an simplify class methods.

@codecov-io
Copy link

codecov-io commented Feb 13, 2019

Codecov Report

Merging #3428 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3428      +/-   ##
==========================================
- Coverage   99.92%   99.92%   -0.01%     
==========================================
  Files         172      172              
  Lines        2838     2819      -19     
==========================================
- Hits         2836     2817      -19     
  Misses          2        2
Impacted Files Coverage Δ
src/modules/Dropdown/Dropdown.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1eb9c2...b5f4373. Read the comment docs.

@layershifter
Copy link
Member Author

@Fabianopb as you spent some effort on Dropdown previously, can you please check these changes? 🙏

@layershifter layershifter merged commit 2d1856e into master Feb 17, 2019
@layershifter layershifter deleted the chore/dropdown-use-eventstack branch February 17, 2019 12:05
@levithomason
Copy link
Member

Released in semantic-ui-react@0.86.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants