perf(parts): add reusable component parts #345
Conversation
| import META from './utils/Meta' | ||
| import { getUnhandledProps } from './utils/propUtils' | ||
|
|
||
| function makePart(partName) { |
There was a problem hiding this comment.
See PR description, this is the component part factory.
levithomason
force-pushed
the
feature/component-parts
branch
2 times, most recently
from
661889a
to
025c6eb
Compare
| @@ -0,0 +1,45 @@ | |||
| #!/usr/bin/env zsh | |||
There was a problem hiding this comment.
Might run into issues with Windows/non-zsh users trying to use this.
There was a problem hiding this comment.
Aye, this was just for my local use to generate the first draft files. The script and files were outdated by the factory function.
levithomason
force-pushed
the
feature/component-parts
branch
2 times, most recently
from
83643c6
to
1421756
Compare
|
Updated with more robust part factories and notes. This is far from done, but will continue to churn on the ideas. Feedback welcome. |
levithomason
force-pushed
the
feature/component-parts
branch
from
1421756
to
8348e40
Compare
levithomason
changed the title
|
This is getting stale, closing. I think PR also suffered from scope creep. I think we should only implement a reusable component for the basic "className only" use case. This is something that will also likely shake out of solving #419, since the base component will handle the same functionality as a reusable component. |
Experiment - Fixes #325
This PR addresses the issue of reusable component parts. These are parts of a component that do not have the
uiclassName. See #325 for more detail.Please offer any comments, ideas, or flames as I think any input on this would be helpful.