Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(CodeSandbox): fix broken icon fonts #3487

Merged
merged 1 commit into from
Mar 10, 2019
Merged

Conversation

layershifter
Copy link
Member

Before

image

After

image

@@ -95,8 +96,6 @@ class ComponentControlsShowCode extends React.Component {
examplePath='/'
example={exampleCode}
dependencies={dependencies}
/* Magic trick to reload sources on passed code update */
key={exampleCode}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need this more, was fixed in react-codesandboxer@3.1.2

@codecov-io
Copy link

Codecov Report

Merging #3487 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3487   +/-   ##
=======================================
  Coverage   99.82%   99.82%           
=======================================
  Files         172      172           
  Lines        2802     2802           
=======================================
  Hits         2797     2797           
  Misses          5        5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8947b0b...34e65b0. Read the comment docs.

@layershifter layershifter merged commit 5940fd8 into master Mar 10, 2019
@delete-merged-branch delete-merged-branch bot deleted the docs/codesandbox-fonts branch March 10, 2019 12:05
@levithomason
Copy link
Member

Released in semantic-ui-react@0.86.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants