perf(docs): improve doc examples performance #3497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3497 +/- ##
=======================================
Coverage 99.82% 99.82%
=======================================
Files 172 172
Lines 2804 2804
=======================================
Hits 2799 2799
Misses 5 5Continue to review full report at Codecov.
|
|
Released in |
mbakiev
pushed a commit
to mbakiev/Semantic-UI-React
that referenced
this pull request
Jun 17, 2019
* perf: remove example mouse listeners * perf: only re-render ads if necessary * docs: align menu sidebar to example on scroll
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doc example pages were getting a bit sluggish. This improves performance a bit by removing some listeners and moving styles to the CSS sheet and implementing more shouldComponentUpdate.