-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Form): make error
prop shorthand in Form.Field
#3603
Conversation
💖 Thanks for opening this pull request! 💖 Here is a list of things that will help get it across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
Codecov Report
@@ Coverage Diff @@
## master #3603 +/- ##
==========================================
+ Coverage 99.83% 99.83% +<.01%
==========================================
Files 174 174
Lines 3100 3104 +4
==========================================
+ Hits 3095 3099 +4
Misses 5 5
Continue to review full report at Codecov.
|
https://semantic-ui.com/behaviors/form.html#validating-on-blur-and-other-events SUI has similar thing actually, will share more thoughts tomorrow. |
Sure, As much as the SUI way attempts to solve the same problem, I think their way can be easily replicated, using already existing components. I don't see this PR being merged unless there is an earlier PR on SUI to deals with the formatting. CSS is not my strong suit, but I am attempting to submit a PR for that. I will welcome any help on that. |
error
prop shorthand in Form.Field
@bubunyo I pushed some updates to this PR, can you please check? 🙏 |
Fixes #3602.
This PR makes
error
prop inForm.Field
shorthand that allows to define custom error message inside it.